Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: define QueryEngine and wrap all things into it #1160

Merged
merged 9 commits into from
Aug 19, 2023
Merged

chore: define QueryEngine and wrap all things into it #1160

merged 9 commits into from
Aug 19, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Aug 17, 2023 •
edited
Loading

Rationale

When I add PhysicalPlanEncoder, I found there have been too many sub-modules in query_engine crate now... And I foudn in fact we always use them together, so I decide to define QueryEngine trait to integrate them.

Detailed Changes

  • Add PhysicalPlanEncoder and its datafusion impl.
  • Refactor Executor.
  • Define QueryEngine to integrate PhysicalPlanner, PhysicalPlanEncoder, Executor.

Test Plan

Test by exist tests.

@Rachelint Rachelint marked this pull request as ready for review August 17, 2023 14:23
ShiKaiWi
ShiKaiWi reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks very great! Lots of messy codes are deleted. I've left some comments for some trivial issues, and let's move on after they are resolved.

df_operator/src/registry.rs Outdated Show resolved Hide resolved
query_engine/src/encoding.rs Outdated Show resolved Hide resolved
query_engine/src/datafusion_impl/encoding.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 50f8a72 into apache:main Aug 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rachelint @ShiKaiWi